hono: add maxBodyBytes guard for JSON parsing#1493
Open
TheodorNEngoy wants to merge 4 commits intomodelcontextprotocol:mainfrom
Open
hono: add maxBodyBytes guard for JSON parsing#1493TheodorNEngoy wants to merge 4 commits intomodelcontextprotocol:mainfrom
TheodorNEngoy wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 74cfc3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Added a changeset so this results in a patch bump for Behavior recap: adds |
felixweinberger
requested changes
Mar 30, 2026
Contributor
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
Thanks - what prompted this PR, is this an issue you actually ran into?
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createMcpHonoApp()includes a built-in JSON body parser that currently reads the full request body.This PR adds a
maxBodyBytesoption (default:1_000_000) and enforces it when parsingapplication/jsonbodies, returning413 Payload too largewhen exceeded. This provides a basic DoS guard while keeping the behavior configurable.Includes tests + README option docs.